Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-multipath SCSI disks for nfs volume #80

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Support non-multipath SCSI disks for nfs volume #80

merged 1 commit into from
Sep 18, 2020

Conversation

yussufsh
Copy link
Contributor

Handle the case when bastion image does not have multipath installed and configured.

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

@ltccci ltccci added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2020
@yussufsh
Copy link
Contributor Author

/kind backport

@ltccci
Copy link
Contributor

ltccci commented Sep 18, 2020

@yussufsh: The label(s) kind/backport, kind/ cannot be applied, because the repository doesn't have them

In response to this:

/kind backport

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yussufsh
Copy link
Contributor Author

/label cherry-pick-approved

bpradipt
bpradipt previously approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @yussufsh

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@bpradipt
Copy link
Contributor

@yussufsh will need a rebase ?

@yussufsh
Support non-multipath SCSI disks for nfs volume
31d36bd 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@ltccci ltccci removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@yussufsh yussufsh requested a review from bpradipt September 18, 2020 12:16
@yussufsh
Copy link
Contributor Author

@yussufsh will need a rebase ?

Yes since other PR got merged first. This is tracking the master branch.
Lessons learned.

bpradipt
bpradipt approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @yussufsh

@ltccci ltccci added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@yussufsh
Copy link
Contributor Author

/cc @Prajyot-Parab

@Prajyot-Parab
Copy link
Collaborator

/approve

@yussufsh
Copy link
Contributor Author

/assign @Prajyot-Parab

@yussufsh
Copy link
Contributor Author

/approve

mkumatag
mkumatag approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltccci
Copy link
Contributor

ltccci commented Sep 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, mkumatag, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Prajyot-Parab,bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bpradipt bpradipt merged commit 7b8da5d into ocp-power-automation:master Sep 18, 2020
@yussufsh
Copy link
Contributor Author

/meow
@mkumatag this bot listen to you always

@ltccci
Copy link
Contributor

ltccci commented Sep 18, 2020

@yussufsh: cat image

In response to this:

/meow
@mkumatag this bot listen to you always

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkumatag
Copy link
Member

/meow
@mkumatag this bot listen to you always

it isn't, @bpradipt merged manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@mkumatag mkumatag mkumatag approved these changes

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yussufsh @ltccci @bpradipt @Prajyot-Parab @mkumatag