added 'ellipse' method to canvasRenderingContext2D #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I've added two commits to make the CI happy, I'll merge after it runs. (I've noticed that ellipse was used in the let ellipse_arc c cx cy rx ry start fin clock_wise =
c##save;
c##translate (Js.float cx) (Js.float cy);
c##scale (Js.float rx) (Js.float ry);
c##arc
(Js.float 0.)
(Js.float 0.)
(Js.float 1.)
(Js.float start)
(Js.float fin)
clock_wise;
c##restoreOne could cleanup this example now that we have ellipse binding. |
hhugo
pushed a commit
to hhugo/opam-repository
that referenced
this pull request
Feb 21, 2024
CHANGES: ## Features/Changes * Mics: fix support for OCaml 5.2 * Compiler: no longer rely on IIFE for scoping variable inside loops * Compiler: avoid parsing bytecode sections twice, jsoo counter part of ocaml#12599 * Lib: add ellipse to canvasRenderingContext2D (@FayCarsons, ocsigen/js_of_ocaml#1555) ## Bug fixes * Compiler: fix global dead code elimination in a toplevel context * Compiler: fix exit-loop-early optim in presence of closure (ocsigen/js_of_ocaml#1561) * Compiler: remove quadratic behavior in generate.ml (ocsigen/js_of_ocaml#1531, ocsigen/js_of_ocaml#1567)
vouillon
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Sep 5, 2024
Integrate "added 'ellipse' method to canvasRenderingContext2D" (ocsigen/js_of_ocaml#1555)
vouillon
pushed a commit
that referenced
this pull request
Oct 29, 2024
* added 'ellipse' method to canvasRenderingContext2D --------- Co-authored-by: Hugo Heuzard <hugo.heuzard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1552