Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obsolete libraries #229

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix obsolete libraries #229

merged 2 commits into from
Sep 20, 2023

Conversation

glondu
Copy link
Contributor

@glondu glondu commented Jul 28, 2023

This pull request removes the need for obsolete libraries:

@glondu
Copy link
Contributor Author

glondu commented Jul 29, 2023

Reported as Debian bug in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042501

src/extensions/staticmod.ml Outdated Show resolved Hide resolved
src/baselib/ocsigen_lib.ml Outdated Show resolved Hide resolved
src/baselib/ocsigen_lib.ml Outdated Show resolved Hide resolved
@hhugo
Copy link
Member

hhugo commented Jul 31, 2023

The diff looks good but I somehow don't trust the test-suite to catch possible semantic change related to regexp. @balat, would you have time to review and maybe test this ?

@glondu glondu force-pushed the fix-obsolete-libraries branch 3 times, most recently from 0865ed4 to 973e6eb Compare August 20, 2023 08:08
@glondu glondu force-pushed the fix-obsolete-libraries branch from 973e6eb to 5ac6399 Compare August 23, 2023 21:28
@glondu
Copy link
Contributor Author

glondu commented Sep 1, 2023

@hhugo @balat Any news on this matter?

FYI, ocsigenserver is scheduled to be removed from Debian testing on 2023-09-15 because of the dependency to pcre.

@hhugo
Copy link
Member

hhugo commented Sep 1, 2023

Ping @balat

@hhugo hhugo requested a review from balat September 11, 2023 11:22
@balat
Copy link
Member

balat commented Sep 20, 2023

Thanks a lot for the PR @glondu and sorry for the late answer.

@balat balat merged commit 809391c into ocsigen:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants