fix: remove type imports from "http" for Deno compatibility (#235)

octokit · Apr 17, 2021 · 256e722 · 256e722
1 parent 6741515
commit 256e722
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -20,11 +20,11 @@
   "dependencies": {
     "@octokit/auth-app": "^3.3.0",
     "@octokit/auth-unauthenticated": "^2.0.4",
-    "@octokit/core": "^3.2.0",
-    "@octokit/oauth-app": "^3.2.0",
-    "@octokit/plugin-paginate-rest": "^2.6.0",
-    "@octokit/types": "^6.0.3",
-    "@octokit/webhooks": "^9.0.0"
+    "@octokit/core": "^3.4.0",
+    "@octokit/oauth-app": "^3.3.2",
+    "@octokit/plugin-paginate-rest": "^2.13.3",
+    "@octokit/types": "^6.13.0",
+    "@octokit/webhooks": "^9.0.1"
   },
   "devDependencies": {
     "@pika/pack": "^0.5.0",

diff --git a/src/middleware/node/index.ts b/src/middleware/node/index.ts
@@ -1,4 +1,8 @@
-import { IncomingMessage, ServerResponse } from "http";
+// remove type imports from http for Deno compatibility
+// see https://github.com/octokit/octokit.js/issues/24#issuecomment-817361886
+// import { IncomingMessage, ServerResponse } from "http";
+type IncomingMessage = any;
+type ServerResponse = any;
 
 import { createNodeMiddleware as oauthNodeMiddleware } from "@octokit/oauth-app";
 import { createNodeMiddleware as webhooksNodeMiddleware } from "@octokit/webhooks";

diff --git a/src/middleware/node/on-unhandled-request-default.ts b/src/middleware/node/on-unhandled-request-default.ts
@@ -1,4 +1,8 @@
-import { IncomingMessage, ServerResponse } from "http";
+// remove type imports from http for Deno compatibility
+// see https://github.com/octokit/octokit.js/issues/24#issuecomment-817361886
+// import { IncomingMessage, ServerResponse } from "http";
+type IncomingMessage = any;
+type ServerResponse = any;
 
 export function onUnhandledRequestDefault(
   request: IncomingMessage,