Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use fork of lru-cache to fix type errors #651

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

wolfy1339
Copy link
Member

See isaacs/node-lru-cache#355

Resolves #ISSUE_NUMBER


Before the change?

  • Type errors would occur when building or consuming the package

After the change?

  • Use a fork of lru-cache that backports the required fix for the type issues

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented, or is being fixed label Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member Author

Unblocks #644

@wolfy1339 wolfy1339 merged commit 3c259fd into main Nov 5, 2024
9 checks passed
@wolfy1339 wolfy1339 deleted the lru-type-errors branch November 5, 2024 19:53
Copy link
Contributor

github-actions bot commented Nov 5, 2024

🎉 This PR is included in version 7.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented, or is being fixed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants