fix: use correct URL to create installation access token for octokit.graphql() and GHES
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reproduces bug reported at probot/probot#1386
oscard0m
requested changes
Oct 20, 2020
test/auth.test.ts
Outdated
| @@ -307,4 +307,50 @@ x//0u+zd/R/QRUzLOw4N72/Hu+UG6MNt5iDZFCtapRaKt6OvSBwy8w== | |||
| token: "secret", | |||
| }); | |||
| }); | |||
|
|
|||
| it.only("createAppAuth with GraphQL + GHES (probot/probot#1386)", async () => { | |||
There was a problem hiding this comment.
sorry I should have made clear that this is still work in progress.
CI will fail if we miss an .only because the test coverage will fall below 100%
There was a problem hiding this comment.
Never thought it this way. Test coverage prevents you from missing .only or commenting tests. Cool!
….graphql()` and GHES The customized baseUrl passed to `@octokit/graphql` is there for legacy reasons. It is no longer necessary since octokit/graphql.js#186
|
🎉 This PR is included in version 3.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes probot/probot#1386