fix: handle baseUrl suffix for GHES
#186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
force-pushed
the
185/handle-ghes-baseurl-suffix
branch
from
9a5f7d8 to
d35209a
Compare
lencioni
reviewed
Sep 9, 2020
lencioni
reviewed
Sep 9, 2020
|
Thanks for working on this! |
Co-authored-by: Joe Lencioni <joe.lencioni@gmail.com>
Co-authored-by: Joe Lencioni <joe.lencioni@gmail.com>
|
🎉 This PR is included in version 4.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
added a commit
to octokit/core.js
that referenced
this pull request
Oct 20, 2020
….graphql()` and GHES The customized baseUrl passed to `@octokit/graphql` is there for legacy reasons. It is no longer necessary since octokit/graphql.js#186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #185
fixes octokit/auth-app.js#111
/cc @lencioni