Add custom assert for readonly collection

octokit · Feb 27, 2014 · 5430718 · 5430718
1 parent 9eb14f3
commit 5430718
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 10 deletions.
diff --git a/Octokit.Tests/Helpers/AssertEx.cs b/Octokit.Tests/Helpers/AssertEx.cs
@@ -58,5 +58,12 @@ public static async Task ThrowsWhenGivenWhitespaceArgument(Func<string, Task> ac
                 await Throws<ArgumentException>(async () => await action(argument));
             }
         }
+
+        public static void IsReadOnlyCollection<T>(object instance) where T : class
+        {
+            var collection = instance as ICollection<T>;
+            // The collection == null case is for .NET 4.0
+            Assert.True(instance is IReadOnlyCollection<T> && (collection == null || collection.IsReadOnly));
+        }
     }
 }
diff --git a/Octokit.Tests/Models/PunchCardTests.cs b/Octokit.Tests/Models/PunchCardTests.cs
@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using Octokit.Response;
+using Octokit.Tests.Helpers;
 using Xunit;
 
 public class PunchCardTests
@@ -61,7 +62,7 @@ public void SetsPunchPointsAsReadOnlyDictionary()
 
             var punchCard = new PunchCard(points);
 
-            Assert.Null(punchCard.PunchPoints as ICollection<PunchCardPoint>);
+            AssertEx.IsReadOnlyCollection<PunchCardPoint>(punchCard.PunchPoints);
         }
     }
 }
diff --git a/Octokit.Tests/Models/SearchCodeRequestTests.cs b/Octokit.Tests/Models/SearchCodeRequestTests.cs
@@ -1,5 +1,5 @@
-using System.Collections.Generic;
-using Octokit;
+using Octokit;
+using Octokit.Tests.Helpers;
 using Xunit;
 
 public class SearchCodeRequestTests
@@ -14,7 +14,7 @@ public void ReturnsAReadOnlyDictionary()
             var result = request.MergedQualifiers();
 
             // If I can cast this to a writeable collection, then that defeats the purpose of a read only.
-            Assert.Null(result as ICollection<string>);
+            AssertEx.IsReadOnlyCollection<string>(result);
         }
     }
 }
diff --git a/Octokit.Tests/Models/SearchIssuesRequestTests.cs b/Octokit.Tests/Models/SearchIssuesRequestTests.cs
@@ -1,5 +1,5 @@
-using System.Collections.Generic;
-using Octokit;
+using Octokit;
+using Octokit.Tests.Helpers;
 using Xunit;
 
 internal class SearchIssuesRequestTests
@@ -14,7 +14,7 @@ public void ReturnsAReadOnlyDictionary()
             var result = request.MergedQualifiers();
 
             // If I can cast this to a writeable collection, then that defeats the purpose of a read only.
-            Assert.Null(result as ICollection<string>);
+            AssertEx.IsReadOnlyCollection<string>(result);
         }
     }
 }
diff --git a/Octokit.Tests/Models/SearchUsersRequestTests.cs b/Octokit.Tests/Models/SearchUsersRequestTests.cs
@@ -1,5 +1,5 @@
-using System.Collections.Generic;
-using Octokit;
+using Octokit;
+using Octokit.Tests.Helpers;
 using Xunit;
 
 internal class SearchUsersRequestTests
@@ -14,7 +14,7 @@ public void ReturnsAReadOnlyDictionary()
             var result = request.MergedQualifiers();
 
             // If I can cast this to a writeable collection, then that defeats the purpose of a read only.
-            Assert.Null(result as ICollection<string>);
+            AssertEx.IsReadOnlyCollection<string>(result);
         }
     }
 }