Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tree Api Client #194

Merged
merged 9 commits into from
Nov 15, 2013
Merged

Conversation

pltaylor
Copy link
Contributor

@pltaylor pltaylor commented Nov 7, 2013

Ready for review. Fixes #132

  • Create TreeClient
    • Implement Get
    • Implement Create
    • Create Interface
  • Create Tree response model
  • Test Tree Client
    • Test Get
    • Test Create
    • Test Serialization
  • Create ObservableTreeClient
    • Create Interface
    • Test ObservableTreeClient
  • Reference in GitHubClient
  • Add files to other projects
    • .Net 4.5
    • Mono
    • MonoAndroid
    • MonoTouch

@pltaylor
Copy link
Contributor Author

With the latest Fake build do I still need to add the files to the other projects?

@haacked
Copy link
Contributor

haacked commented Nov 11, 2013

With the latest Fake build do I still need to add the files to the other projects?

Not manually. Just run .\script\build.cmd in the root of the repository to fix it up.

@pltaylor
Copy link
Contributor Author

I did it manually for this PR, but it is fantastic to know I won't have to in the future!!

@shiftkey
Copy link
Member

You'll need to merge master into this branch (probably some csproj conflicts yay!)

EDIT: nope, ApiUrls.cs

@shiftkey shiftkey mentioned this pull request Nov 14, 2013
@shiftkey shiftkey merged commit ce5f8e4 into octokit:master Nov 15, 2013
@shiftkey
Copy link
Member

I updated the Mono* files inline and merged this in by hand. Thanks for the work.

@pltaylor
Copy link
Contributor Author

I'm sorry this needed the mono files updated. I thought I did that.

@shiftkey
Copy link
Member

@pltaylor that's okay.

I made a change recently to the script to make it more thorough after some changes slipped through, so it's not your fault.

@pltaylor
Copy link
Contributor Author

Thanks for the scapegoat...but I did it manually....so the blame, as insignificant as it may be, rests over here.

@pltaylor pltaylor deleted the ImplementTreesApi branch November 15, 2013 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git DB API: Implement the Trees API
3 participants