Add support to get raw file content as byte[] #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xced
force-pushed
the
raw-content
branch
2 times, most recently
from
42305ec to
a1d690b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2151 +/- ##
==========================================
- Coverage 65.89% 65.86% -0.03%
==========================================
Files 546 546
Lines 14251 14293 +42
Branches 836 838 +2
==========================================
+ Hits 9390 9414 +24
- Misses 4703 4720 +17
- Partials 158 159 +1
|
This allows to spare a little over 100ms in my tests on small files vs using the `GetAllContentsByRef` API. Fixes octokit#1651
|
@shiftkey I just rebased onto master. Do you think you'll get some time to review this pull request sooner or later? |
shiftkey
approved these changes
Apr 12, 2020
| @@ -2363,7 +2363,7 @@ public static Uri RepositoryArchiveLink(string owner, string name, ArchiveFormat | |||
| /// <returns>The <see cref="Uri"/> for getting the contents of the specified repository and path</returns> | |||
| public static Uri RepositoryContent(string owner, string name, string path, string reference) | |||
| { | |||
| return "repos/{0}/{1}/contents/{2}?ref={3}".FormatUri(owner, name, path, reference); | |||
| return "repos/{0}/{1}/contents/{2}?ref={3}".FormatUri(owner, name, path == "/" ? "" : path, reference); | |||
There was a problem hiding this comment.
This is a nice bit of cleanup for my more explicit example above - thanks!
|
release_notes: added |
|
Thanks for merging and releasing version 0.47.0! 🎉 |
nickfloyd
added
Type: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to spare a little over 100ms in my tests on small files vs using the
GetAllContentsByRefAPI.Fixes #1651