References API implementation

[khellang]

Fixes #130

It's yours if you want it 😄

I'd love some feedback on how you'd like the GetAll overload that takes the subNamespace parameter. I think it might be better to use a enum value here. Do you do any validation on the client anywhere?

I also snuck some namespace additions in here. Tell me if you'd like me to remove this commit.

[shiftkey]

It's yours if you want it 😄

Real talk: I love how people get to this stuff before I can get around to it. Thanks!

[shiftkey]

I'd love some feedback on how you'd like the GetAll overload that takes the subNamespace parameter. I think it might be better to use a enum value here. Do you do any validation on the client anywhere?

The sub-namespace is a handy way organise similar references - heads and tags are some of the common conventions, pulls is another one you might have seen - but I don't think there's value in constraining it to a specific enum.

When a sub-namepsace doesn't exist, the server returns 404 - we should check for that and propagate a more helpful exception to the user.

[shiftkey]

Nice 💄 change - can we drop the whitespace between this and the other using statements?

[shiftkey]

Looking good so far, most of the feedback is about cosmetic stuff and typos.

Some integration tests would be awesome (we have helpers for creating repositories and disposing them at the end of the test) but I don't consider it a blocker to merging this in.

That "sub-namespace not found" code path I think is the only technical thing I'd like resolved at this stage.

[khellang]

Thanks for great feedback! I also think it would be better to just drop the namespaces. They provide no value in the test project, I just added them for consistency.

The whitespace in the using directives is a result of R#'s "optimize using directives", there should be a DotSettings for the sln with a separate one for test projects so it would be easier for contributors to follow the coding/naming style. Want me to file an issue?

I'll fix the stuff mentioned ASAP 😉

BTW, I had trouble building the sln in VS2013. The build seems very brittle, about 3 out of 4 builds breaks with an error complaining about code analysis. I'll add a screenshot to #143

[khellang]

One more thing. The GetAll with sub-namespace, what do you think of the name? I see that other clients have GetFor and GetAllFor names. Should we call it GetAllForSubNamespace?

[khellang]

@shiftkey Now the only thing missing is the 404 check and error message 😄

[shiftkey]

Were you going to drop the namespace additions for the tests?

[shiftkey]

I've opened #242 for us to track that 404 path, and I'll commit a failing integration test so we don't forget about it either.

Thanks for the contribution!