Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the slug field to the GitHubApp response object #2391

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

Whitestripe7773
Copy link
Contributor

I have fixed the issue #2335.

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @Whitestripe7773 thanks for the contributions here. ❤️ Let me know if you wouldn't mind updating the tests here. It's not a show-stopper given this is just a property addition to a response object but it would be nice to have the coverage (contractwise for the API).

Thanks again!

@nickfloyd nickfloyd changed the title fix #2335 Adds the slug field to the GitHubApp response object Jul 13, 2022
@nickfloyd nickfloyd merged commit 7384b46 into octokit:main Jul 13, 2022
@nickfloyd
Copy link
Contributor

release_notes: Adds the slug field to the GitHubApp response object

@nickfloyd nickfloyd added Type: Feature New feature or request and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants