Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trimming trailing slashes from user passed paths #2486

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Trimming trailing slashes from user passed paths #2486

merged 1 commit into from
Jul 15, 2022

Conversation

JonruAlveus
Copy link
Collaborator

@JonruAlveus JonruAlveus commented Jul 15, 2022 •
edited
Loading

Fixes #2390
Fixes #2243

Trimming trailing slashes from user passed paths that appear before query string parameters

nickfloyd
nickfloyd approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution!

@nickfloyd nickfloyd merged commit 13ba84b into octokit:main Jul 15, 2022
@nickfloyd
Copy link
Contributor

release_notes: Trims trailing slashes from user passed paths that appear before query string parameters

@JonruAlveus JonruAlveus deleted the 2390_TrimUserPassedPathParameters branch July 21, 2022 04:41
@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Milestone
No milestone
2 participants
@JonruAlveus @nickfloyd