Adding 4 new Reaction delete routes and obsoleting existing routes

[JonruAlveus]

fixes #2490

#2430

[nickfloyd]

Hey @JonruAlveus thanks for the contributions here. I just commented on the first few files regarding some parameter naming - let me know your thoughts; the changes would need to be applied through the entire change set.

[nickfloyd]

For generation sake (future concern) and ease of consumption, I'd like to name these to match the names in the OpenAPI descriptions as closely as possible.

Suggested change

	/// <param name="number">The comment id</param>
	/// <param name="reaction">The reaction id</param>
	/// <returns></returns>
	IObservable<Unit> Delete(string owner, string name, int number, int reaction);
	/// <param name="commentId">The comment id</param>
	/// <param name="reactionId">The reaction id</param>
	/// <returns></returns>
	IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId);

[JonruAlveus]

👍

[nickfloyd]

Suggested change

	/// <param name="number">The comment id</param>
	/// <param name="reaction">The reaction id</param>
	/// <returns></returns>
	IObservable<Unit> Delete(long repositoryId, int number, int reaction);
	/// <param name="commentId">The comment id</param>
	/// <param name="reactionId">The reaction id</param>
	/// <returns></returns>
	IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);

[JonruAlveus]

👍

[nickfloyd]

Suggested change

	/// <param name="number">The issue id</param>
	/// <param name="reaction">The reaction id</param>
	/// <returns></returns>
	IObservable<Unit> Delete(string owner, string name, int number, int reaction);
	/// <param name="issueId">The issue id</param>
	/// <param name="reactionId">The reaction id</param>
	/// <returns></returns>
	IObservable<Unit> Delete(string owner, string name, int issueId, int reactionId);

[JonruAlveus]

👍

[nickfloyd]

Suggested change

	/// <param name="number">The comment id</param>
	/// <param name="reaction">The reaction id</param>
	/// <returns></returns>
	IObservable<Unit> Delete(long repositoryId, int number, int reaction);
	/// <param name="commentId">The comment id</param>
	/// <param name="reactionId">The reaction id</param>
	/// <returns></returns>
	IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);

[JonruAlveus]

👍

[JonruAlveus]

@nickfloyd all changes made!

[nickfloyd]

Thanks for the changes here! I was looking at Octokit/Helpers/ApiUrls.cs, and it looks like that whole class needs to be refactored to fit a less obscure naming scheme - lots of use of the nondescript number and the like.

I've created an issue for that one so that we can move forward with your changes here.

[nickfloyd]

release_notes: Adds 4 new Reaction delete routes to replace the existing obsolete routes