Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct methods and URL to generate release notes #2592

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

rdeago
Copy link
Contributor

@rdeago rdeago commented Oct 7, 2022

Fixes #2589.

I also changed the documentation for GenerateReleaseNotes, adding links to relevant GitHub docs, an example of generated text, and clearer example code.

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@nickfloyd nickfloyd merged commit fa29939 into octokit:main Oct 7, 2022
@nickfloyd
Copy link
Contributor

release_notes: Use correct methods and URL to generate release notes

@rdeago
Copy link
Contributor Author

rdeago commented Oct 8, 2022

Wow @nickfloyd that was fast! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReleasesClient.GenerateReleaseNotes uses the wrong URL and HTTP method
2 participants