Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventsClient fix - ids are string, not ints #264

Merged
merged 3 commits into from
Dec 18, 2013

Conversation

shiftkey
Copy link
Member

The ids for the entities in an event are ints, but the id of the event itself is not:

[
  {
    "type": "Event",
    "public": true,
    "payload": {
    },
    "repo": {
      "id": 3,
      "name": "octocat/Hello-World",
      "url": "https://api.github.com/repos/octocat/Hello-World"
    },
    "actor": {
      "id": 1,
      "login": "octocat",
      "gravatar_id": "somehexcode",
      "avatar_url": "https://github.com/images/error/octocat_happy.gif",
      "url": "https://api.github.com/users/octocat"
    },
    "org": {
      "id": 1,
      "login": "github",
      "gravatar_id": "somehexcode",
      "url": "https://api.github.com/orgs/github",
      "avatar_url": "https://github.com/images/error/octocat_happy.gif"
    },
    "created_at": "2011-09-06T17:26:27Z",
    "id": "12345"
  }
]

Resolves #263

@half-ogre
Copy link
Contributor

:shipit:

shiftkey added a commit that referenced this pull request Dec 18, 2013
EventsClient fix - ids are string, not ints
@shiftkey shiftkey merged commit 9f2bb17 into master Dec 18, 2013
@shiftkey shiftkey deleted the 263-ids-are-not-always-ints branch December 18, 2013 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specified cast not valid when retrieving events
2 participants