-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Fix handling for Streams in IConnection for raw content #2791
Conversation
Looks like this got closed by accident because I put the wrong |
05a96b6
to
b35aa89
Compare
c694892
to
5bf3c82
Compare
@nickfloyd Anything more you need from me to progress this fix? |
I do think it'd be possible to write a test for this case in |
232e643
to
51d044b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Fix
NullReferenceException
if raw content was handled as a string rather than a stream byHttpClientAdapter.BuildResponse()
.I haven't added a test for this, but have validated that the apps that surfaced this issue are working when using a local build of Octokit including this change. If you can direct me to exactly where you'd like a test for this, I'll add one.
Resolves #2789
Before the change?
NullReferenceException
would be thrown.After the change?
Pull request checklist
Does this introduce a breaking change?