Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespaces for Artifacts models #2862

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Fix namespaces for Artifacts models #2862

merged 1 commit into from
Jan 25, 2024

Conversation

thomhurst
Copy link
Contributor

Resolves #2861

Fixes namespace clashes

@thomhurst thomhurst mentioned this pull request Jan 25, 2024
Closed
1 task
amis92
amis92 approved these changes Jan 25, 2024
View reviewed changes
Copy link

@amis92 amis92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

nickfloyd
nickfloyd approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up here, I completely missed this during the review. ❤️

@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Jan 25, 2024
@nickfloyd nickfloyd merged commit c9ddf3e into octokit:main Jan 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

@amis92 amis92 amis92 approved these changes

@darthkurak darthkurak darthkurak approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: class Artifact is in global namespace
4 participants
@thomhurst @nickfloyd @amis92 @darthkurak