Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Repository Comments API #408

Closed
wants to merge 10 commits into from
Closed

Implement Repository Comments API #408

wants to merge 10 commits into from

Conversation

wfroese
Copy link

@wfroese wfroese commented Mar 1, 2014

See issue #332 for details.

@haacked
Copy link
Contributor

haacked commented Mar 3, 2014

Looks good! Just merge in (or rebase against) master so I can hit that green button. :)

@wfroese
Copy link
Author

wfroese commented Mar 4, 2014

Is that what you were looking for?

@haacked
Copy link
Contributor

haacked commented Mar 4, 2014

Hmm, I still can't merge it. It says there are conflicts. Did you make sure to fetch latest?

@wfroese
Copy link
Author

wfroese commented Mar 4, 2014

I did. The commit history looks like it contains everything in master as well. And now the build is failing too, so I'll look into that...

@haacked
Copy link
Contributor

haacked commented Mar 4, 2014

-575

^^^ That's what I'm seeing. That indicates that your branch isn't up to date with master on the server.

@wfroese
Copy link
Author

wfroese commented Mar 4, 2014

It looks like the latest thing merged into master is pull request #410, and the build is now telling me that a file from that commit is missing in Octokit-MonoAndroid.csproj, Octokit-Monotouch.csproj, etc.

Not really sure where to go from here...

@haacked
Copy link
Contributor

haacked commented Mar 4, 2014

Try running

.\build.cmd FixProjects

@haacked
Copy link
Contributor

haacked commented Mar 4, 2014

And then commit those changes and push.

@wfroese
Copy link
Author

wfroese commented Mar 4, 2014

If it still won't let you merge, then I'm at a loss unfortunately. Doing a fetch does nothing (because it's presumably up to date), and the same happens for merging master into this branch.

@haacked
Copy link
Contributor

haacked commented Mar 4, 2014

Ok, I'll take a look at it tomorrow.

@haacked
Copy link
Contributor

haacked commented Mar 4, 2014

So it looks like you pushed it in a conflicted state. When I pulled it locally, there was still a merge conflict left to resolve. I resolved it and pushed it to a new branch.

@haacked haacked closed this in #413 Mar 4, 2014
@haacked
Copy link
Contributor

haacked commented Mar 4, 2014

thanks for your contribution!

@wfroese
Copy link
Author

wfroese commented Mar 4, 2014

Oh geez. Thanks Phil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants