-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Repository Comments API #408
Conversation
Looks good! Just merge in (or rebase against) master so I can hit that green button. :) |
To not require cancellation token
Is that what you were looking for? |
Hmm, I still can't merge it. It says there are conflicts. Did you make sure to fetch latest? |
I did. The commit history looks like it contains everything in master as well. And now the build is failing too, so I'll look into that... |
It looks like the latest thing merged into master is pull request #410, and the build is now telling me that a file from that commit is missing in Octokit-MonoAndroid.csproj, Octokit-Monotouch.csproj, etc. Not really sure where to go from here... |
Try running .\build.cmd FixProjects |
And then commit those changes and push. |
If it still won't let you merge, then I'm at a loss unfortunately. Doing a fetch does nothing (because it's presumably up to date), and the same happens for merging master into this branch. |
Ok, I'll take a look at it tomorrow. |
So it looks like you pushed it in a conflicted state. When I pulled it locally, there was still a merge conflict left to resolve. I resolved it and pushed it to a new branch. |
Oh geez. Thanks Phil! |
See issue #332 for details.