Fix service status methods. Fixes #1107 #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tarebyte how does this look to you? |
Dmaggio1974
approved these changes
Nov 2, 2019
|
Marked as breaking (due to new endpoints returning a slightly different body structure, but not significant enough to bump the major version IMO. |
nickfloyd
added
Type: Breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #1107 the service status methods that were using the old status.github.com, replacing them with the updated URL githubstatus.com.
Also a new method was added and tested:
github_status_summarythat retrieves both thestatusand thecomponents(status messages).One thing to take into account is that with the new API endpoints, the structure has changed, so the old
bodynode is now calleddescriptioninside each component, breaking some backwards compatibility.