Escape label names with URL characters #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Fryguy
force-pushed
the
fix_labels_with_url_chars
branch
from
89a7f12 to
91e0d4d
Compare
This comment has been minimized.
This comment has been minimized.
Fryguy
force-pushed
the
fix_labels_with_url_chars
branch
from
91e0d4d to
fcd8564
Compare
Fryguy
changed the title
|
@tarebyte This is ready to go! |
|
@tarebyte Is this good to merge? |
|
@tarebyte Are you good with this change? |
Fryguy
force-pushed
the
fix_labels_with_url_chars
branch
from
fcd8564 to
1775e35
Compare
|
Rebased against 4-stable to verify on the new 3.0 test suite/ @tarebyte Is there any else you need me to do here to get this in? Should it go against a different branch or multiple branches? |
Fryguy
added a commit
to Fryguy/manageiq-release
that referenced
this pull request
May 26, 2022
octokit/octokit.rb#1297 is merged and released in octokit 4.23.0
Fryguy
added a commit
to ManageIQ/multi_repo
that referenced
this pull request
Mar 24, 2023
octokit/octokit.rb#1297 is merged and released in octokit 4.23.0 (transferred from ManageIQ/manageiq-release@03760a4)
Fryguy
added a commit
to ManageIQ/multi_repo
that referenced
this pull request
Mar 24, 2023
octokit/octokit.rb#1297 is merged and released in octokit 4.23.0 (transferred from ManageIQ/manageiq-release@03760a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1296
@tarebyte This is WIP because I am having trouble recording the VCR cassettes, and I'm not sure what I'm doing wrong. I could probably use some pointers there.