Correctly raise Octokit::TooManyRequests when hitting secondary rate limit #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…limit The server returns 403 for a large swath of errors, and then client then re-raises them as more appropriate errors via inspecting the body of the reponse. Adding a case to raise Octokit::TooManyRequests for the secondary rate limit error as well.
jasonopslevel
commented
Dec 13, 2021
| @@ -68,6 +68,8 @@ def self.error_for_401(headers) | |||
| def self.error_for_403(body) | |||
| if body =~ /rate limit exceeded/i | |||
There was a problem hiding this comment.
An alternative would be to instead just do:
Suggested change
| if body =~ /rate limit exceeded/i | |
| if body =~ /rate limit/i |
However, went with the more explicit approach for now.
joelthecoder
approved these changes
Mar 14, 2022
mattpage
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server returns 403 for a large swath of errors, and then client then
re-raises them as more appropriate errors via inspecting the body of the
response. Adding a case to raise Octokit::TooManyRequests for the secondary
rate limit error as well.
For example, the body returned for a 'primary' rate limit:
and the body for the secondary rate limit: