Specify TargetRubyVersion: 2.7 in .rubocop.yml
#1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up octokit#1454. gemspec `required_ruby_version` requires 2.7 and higher, so specify `TargetRubyVersion` to 2.7. Some syntax detected by updating to 2.7 applies. It also removes `Gemspec/RequiredRubyVersion` cop from .rubocop_todo.yml to enable the cop so that version mismatch can be detected.
kfcampbell
reviewed
Feb 17, 2023
| @@ -163,10 +163,10 @@ def inspect | |||
| inspected.gsub! @bearer_token, '********' if @bearer_token | |||
| # Only show last 4 of token, secret | |||
| if @access_token | |||
| inspected.gsub! @access_token, "#{'*' * 36}#{@access_token[36..-1]}" | |||
| inspected.gsub! @access_token, "#{'*' * 36}#{@access_token[36..]}" | |||
There was a problem hiding this comment.
Do you mind explaining this change to me? Were we only showing the first, second, and third from last characters in the token?
There was a problem hiding this comment.
String#[s..-1] and String#[s..] are compatible with the endless range syntax added in Ruby 2.6.
kfcampbell
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior
Before the change?
Version mismatch between
required_ruby_versionof gemspec andTargetRubyVersionof .rubocop.yml. Therefore, some new syntax up to Ruby 2.7 is not used.After the change?
gemspec
required_ruby_versionrequires 2.7 and higher, so specifyTargetRubyVersionto 2.7. Some syntax detected by updating to 2.7 applies.It also removes
Gemspec/RequiredRubyVersioncop from .rubocop_todo.yml to enable the cop so that version mismatch can be detected.Other information
This PR is follow up #1454.
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance