Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Renew access token with refresh access token #1651

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

gigDevelopment10
Copy link
Contributor

@gigDevelopment10 gigDevelopment10 commented Dec 29, 2023

Resolves #I1652


Before the change?

  • Missing functionality to renew an access token when github app is authenticated.

After the change?

  • Expired access tokens can be renewed using refresh access token.
  • Method added in lib/octokit/client/users.rb

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • No

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gigDevelopment10 solid commits here! Thank you for doing this! ❤️

@nickfloyd nickfloyd changed the title Renew access token with refresh access token feat: Renew access token with refresh access token Jan 16, 2024
@nickfloyd nickfloyd merged commit 18c148f into octokit:main Jan 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants