Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the /hooks endpoint #336

Merged
merged 1 commit into from
Nov 13, 2013
Merged

Add support for the /hooks endpoint #336

merged 1 commit into from
Nov 13, 2013

Conversation

danmcclain
Copy link
Contributor

/hooks lists the supported hooks for GitHub
and their parameters

@coveralls
Copy link

Coverage Status

Coverage increased (+0.68%) when pulling 32c1a5e on danmcclain:master into 7f6a5d4 on octokit:master.

@@ -1,7 +1,7 @@
module Octokit
class Client

# Methods for the the unpublished Emojis API
# Methods for the unpublished Emojis API
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh look, I guess it's not secret anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pengwynn Would you like for me to remove the "unpublished" part?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great.

/hooks lists the supported hooks for GitHub
and their parameters
@danmcclain
Copy link
Contributor Author

@pengwynn s/hook_definitions/available_hooks/ and removes the "Unpublished" like discussed 👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling b26387d on danmcclain:master into 7f6a5d4 on octokit:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling b26387d on danmcclain:master into 7f6a5d4 on octokit:master.

pengwynn added a commit that referenced this pull request Nov 13, 2013
Add support for the /hooks endpoint
@pengwynn pengwynn merged commit 4d3ac13 into octokit:master Nov 13, 2013
@pengwynn
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants