Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v6 #401

Merged
merged 13 commits into from
Feb 23, 2024
Merged

feat: v6 #401

merged 13 commits into from
Feb 23, 2024

Conversation

wolfy1339
Copy link
Member

BREAKING CHANGE: remove code and headers properties that were previously deprecated
BREAKING CHANGE: switch package to ESM instead of CommonJS

@wolfy1339
fix: remove deprecated code
6918a32 
BREAKING CHANGE: remove `code` and `headers` properties that were previously deprecated
@wolfy1339
build: output ESM
75a350d 
BREAKING CHANGE: switch package to ESM instead of CommonJS
@wolfy1339 wolfy1339 added Type: Feature New feature or request Type: Breaking change Used to note any change that requires a major version bump labels Feb 17, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 marked this pull request as ready for review February 17, 2024 22:39
@wolfy1339 wolfy1339 mentioned this pull request Feb 21, 2024
Closed
@wolfy1339 wolfy1339 requested review from gr2m and nickfloyd February 22, 2024 23:08
gr2m
gr2m approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Exciting to see the @octokit packages transition to ESM!

@wolfy1339 wolfy1339 merged commit d73dee6 into main Feb 23, 2024
7 checks passed
@wolfy1339 wolfy1339 deleted the beta branch February 23, 2024 00:58
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@benjamin-guibert
Copy link

Hi, I've some troubles with the v6, my code can't find the module @octokit/request-error anymore. Any idea what's missing on my repo?

This branch (failing build)

@wolfy1339
Copy link
Member Author

Please open an issue.

We switched to ESM builds and using the exports field in package.json

@wolfy1339
Copy link
Member Author

@benjamin-guibert It seems to be an issue with "moduleResolution": "bundler", it works fine with node16 and nodenext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@nickfloyd nickfloyd Awaiting requested review from nickfloyd

Assignees
No one assigned
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfy1339 @benjamin-guibert @gr2m