Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: start testing against 22 #712

Merged
merged 1 commit into from
Jul 12, 2024
Merged

ci: start testing against 22 #712

merged 1 commit into from
Jul 12, 2024

Conversation

wolfy1339
Copy link
Member

Adds Node 22 to the node_versions matrix

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 11, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 changed the title ci start testing against 22 ci: start testing against 22 Jul 11, 2024
@wolfy1339 wolfy1339 force-pushed the remove-eol-node-versions branch from 56bc565 to adb446a Compare July 11, 2024 23:05
@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 12, 2024

I think we should also test against 23.

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oscard0m oscard0m merged commit bc059c8 into main Jul 12, 2024
13 checks passed
@oscard0m oscard0m deleted the remove-eol-node-versions branch July 12, 2024 15:46
@wolfy1339
Copy link
Member Author

NodeJS v23 is not even released yet.

I don't feel like we should be testing pre-release versions of Node.

Copy link

🎉 This issue has been resolved in version 9.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants