Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #72 so it can be used in older versions of Probot #73

Closed
tcbyrd opened this issue Apr 11, 2019 · 5 comments
Closed

Backport #72 so it can be used in older versions of Probot #73

tcbyrd opened this issue Apr 11, 2019 · 5 comments
Assignees
@gr2m

Comments

@tcbyrd
Copy link

tcbyrd commented Apr 11, 2019 •
edited
Loading

Discussed here: #72 (comment)

Some integrations need to be able to use the fix from #72 in older versions of Probot (at least 7.5.0 that I know of), so wanted to discuss here if we need to backport webhooks.js in order to facilitate this.

cc @scepticulous @gimenete @gr2m
@dennissivia
Copy link

I agree, it would be amazing if we could create two PRs to probot. One to master and one to the 7.x branch and release 7.5.1 of probot with would include the fix in #72 included. This way it is just a patchlevel update for webhook.js and for probot and since the change only fixes a bug, it looks like a good option.

@gr2m
Copy link
Contributor

gr2m commented Apr 12, 2019

We can update probot 7 to the latest @ocotkit/webhooks, I see no reason not to

@gr2m gr2m self-assigned this Apr 12, 2019
@gr2m gr2m mentioned this issue Apr 12, 2019
Merged
@gr2m
Copy link
Contributor

gr2m commented Apr 12, 2019

👉 probot@7.5.3 Does that work?

@dennissivia
Copy link

dennissivia commented Apr 12, 2019 •
edited
Loading

👉 probot@7.5.3 Does that work?

✅ Works like a charm 👏
I tested a direct comparison of 7.5.2 and 7.5.3 and that version bump makes the problem go away 💟

IMO we can close this backport issue 👍

dennissivia added a commit to integrations/slack that referenced this issue Apr 12, 2019
@dennissivia
Fixes signature verification for ansi codes
2657c65 
Updates the requires version of probot, which includes
an update of octokit/webhook.js that fixes signature verification
for payloads that contain ANSI codes. In particular `ESC` sequences.
See:
* octokit/webhooks.js#71
* octokit/webhooks.js#73
* probot/probot#912
dennissivia added a commit to integrations/slack that referenced this issue Apr 12, 2019
@dennissivia
Fixes signature verification for ansi codes
92dfbb8 
Updates the requires version of probot, which includes
an update of octokit/webhook.js that fixes signature verification
for payloads that contain ANSI codes. In particular `ESC` sequences.
See:
* octokit/webhooks.js#71
* octokit/webhooks.js#73
* probot/probot#912
@dennissivia dennissivia mentioned this issue Apr 12, 2019
Merged
@gr2m
Copy link
Contributor

gr2m commented Apr 12, 2019

Thanks for checking 👍

@gr2m gr2m closed this as completed Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gr2m gr2m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gr2m @dennissivia @tcbyrd