Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): Add missing class functions #55

Merged
merged 8 commits into from
Jan 26, 2019
Merged

Conversation

wolfy1339
Copy link
Member

No description provided.

@wolfy1339
Copy link
Member Author

This should be ready to go @gr2m

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

scripts/generate-types.js Outdated Show resolved Hide resolved
scripts/generate-types.js Outdated Show resolved Hide resolved
WebhookPayloadWithRepository does not exist, it can be anything.
`event` arguments can be string or an array of strings
Use them from the imported http module
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@gr2m gr2m merged commit 79fcec2 into octokit:master Jan 26, 2019
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wolfy1339 wolfy1339 deleted the patch-1 branch January 27, 2019 04:03
wolfy1339 added a commit to wolfy1339/webhooks.js that referenced this pull request Mar 29, 2019
gr2m pushed a commit that referenced this pull request Mar 29, 2019
wolfy1339 added a commit to wolfy1339/webhooks.js that referenced this pull request Apr 1, 2019
gr2m pushed a commit that referenced this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants