Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of embedded tweets #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

randycoulman
Copy link

Twitter provides several options for customizing embedded tweets. The full list is available in their developer documentation. Of particular interest are the ability to turn off embedded media and the ability to show only the tweet and not the surrounding conversation.

This PR adds the ability to provide optional keyword arguments after the tweet status URL.

The parsing code is modeled after some of the bulit-in tags in Liquid itself. I made one change from that pattern, though, because the attribute parsing code was also catching the URL, resulting in a data-https attribute being added.

I did not implement any kind of whitelist or blacklist for keys, though that might be desirable. I can add it in if you think it necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant