Allow customization of embedded tweets #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitter provides several options for customizing embedded tweets. The full list is available in their developer documentation. Of particular interest are the ability to turn off embedded media and the ability to show only the tweet and not the surrounding conversation.
This PR adds the ability to provide optional keyword arguments after the tweet status URL.
The parsing code is modeled after some of the bulit-in tags in Liquid itself. I made one change from that pattern, though, because the attribute parsing code was also catching the URL, resulting in a
data-https
attribute being added.I did not implement any kind of whitelist or blacklist for keys, though that might be desirable. I can add it in if you think it necessary.