Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to v3.0.0 #18

Merged
merged 8 commits into from
Dec 1, 2022
Merged

Upgrade to v3.0.0 #18

merged 8 commits into from
Dec 1, 2022

Conversation

riversyang
Copy link
Member

@riversyang riversyang commented Nov 10, 2022 •
edited
Loading

All Changes

  • Add field evm_chain_id to RegistryDepositMessage::RegisterAppchain as Option<U64>.
  • The evm_chain_id of appchain can be changed by function update_appchain_metadata now.
  • Change field function_spec_url and github_release of RegistryDepositMessage::RegisterAppchain to Option<String>.
  • Remove RegistryDepositMessage::UpvoteAppchain and RegistryDepositMessage::DownvoteAppchain.
  • Change appchain state transition process. Make the following changes to enum AppchainState:
    • Rename AppchainState::Auditing to AppchainState::Audited.
    • Rename AppchainState::InQueue to AppchainState::Voting.
    • Remove AppchainState::Staging, AppchainState::Frozen and AppchainState::Broken.
    • Add AppchainState::Closing.
    • Rename AppchainState::Dead to AppchainState::Closed.
  • Remove public function start_auditing_appchain, conclude_voting_score and count_voting_score.
  • Add public function start_voting_appchain and start_booting_appchain.
  • Remove role operator_of_counting_voting_score.
  • Add role octopus_council. Only account with this role can call function start_booting_appchain.
  • Remove field voting_result_reduction_percent, counting_interval_in_seconds and latest_evm_chain_id from RegistrySettings.

@riversyang
Change features related to evm_chain_id.
2073c6b 
The `evm_chain_id` of an appchain will no longer be assigned automatically.
@riversyang
Refactor structure of modules.
42743d2
@riversyang
Change design of business functions.
3f9e9e7 
* Remove implementation related to user voting.
* Add role 'octopus council'.
* Remove role 'operator of counting voting score'.
* Upgrade crate 'workspaces' to version '0.6'.
@riversyang riversyang mentioned this pull request Dec 1, 2022
Merged
@riversyang riversyang merged commit f7a386a into main Dec 1, 2022
@riversyang riversyang deleted the v3.0.0 branch December 1, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsxyl hsxyl hsxyl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riversyang @hsxyl