Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolving optional public library #54

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

moyodiallo
Copy link
Collaborator

This is a fix for the issue #53. The public optional libraries were resolved.

@moyodiallo moyodiallo force-pushed the fix-adding-optional-public-lib branch 2 times, most recently from a2d6fd3 to 94be50f Compare October 24, 2023 13:05
This is a fix for the issue ocurrent#53. The public optional libraries were
resolved.
@moyodiallo moyodiallo force-pushed the fix-adding-optional-public-lib branch from 94be50f to 13fbac0 Compare October 24, 2023 13:47
@moyodiallo moyodiallo requested a review from MisterDA October 24, 2023 14:17
@moyodiallo moyodiallo merged commit 2c33c7b into ocurrent:master Oct 25, 2023
1 check passed
@moyodiallo moyodiallo added the bug Something isn't working label Oct 25, 2023
@moyodiallo moyodiallo deleted the fix-adding-optional-public-lib branch October 25, 2023 08:32
moyodiallo added a commit to moyodiallo/opam-repository that referenced this pull request Oct 31, 2023
CHANGES:

- Fix the issue ocurrent/opam-dune-lint#53. Skip resolving a public library when it is added as optional dependency(dune's libraries stanza) (@moyodiallo ocurrent/opam-dune-lint#54).

- Print all the errors before the exit (@moyodiallo ocurrent/opam-dune-lint#55).
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
CHANGES:

- Fix the issue ocurrent/opam-dune-lint#53. Skip resolving a public library when it is added as optional dependency(dune's libraries stanza) (@moyodiallo ocurrent/opam-dune-lint#54).

- Print all the errors before the exit (@moyodiallo ocurrent/opam-dune-lint#55).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant