Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sexplib parse fails #67

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

moyodiallo
Copy link
Collaborator

Fixes #66

@moyodiallo moyodiallo merged commit 14f790e into ocurrent:master Mar 28, 2024
1 check passed
@moyodiallo moyodiallo deleted the fix-parse branch March 28, 2024 17:12
mseri pushed a commit to ocaml/opam-repository that referenced this pull request Apr 22, 2024
CHANGES:

- Fix the issue ocurrent/opam-dune-lint#68, with Sexp format dune parse quoted string by escaping "%{" to become "\%{" that OpamFile module can't parse. So we switch to Csexp format which doesn't change quoted string (@moyodiallo ocurrent/opam-dune-lint#69).

- Fix the issue ocurrent/opam-dune-lint#66, when the content of dune-project file ends up with a comment, the Sexplib parse fails because the last `)` falls into the comment (@moyodiallo ocurrent/opam-dune-lint#67).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sexplib.Sexp.of_string: incomplete S-expression while in state Parsing_list
1 participant