Add a new lint check: disallow the extra-files field in opam packages #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
There's a great alternative - extra-sources - that should be used instead.
hannesm
force-pushed
the
lint-no-extra-files
branch
from
affa276
to
d6df6db
Compare
benmandrew
approved these changes
May 23, 2024
|
We talked about ocaml/opam-repository#25876 in the opam repo maintainer meeting yesterday, and the maintenance team was all in favor. I've asked them to make the approval explicit on the issue. But iiuc, we want to be sure to wait to merge this until after the changes go in effect on the opam-repository, so we'll wait to hear from you, @hannesm. Thanks :) |
|
I'm going to convert this to a draft, just as an indicator to us that is not waiting to be merged. |
|
This should now be merged and pushed to live. |
punchagan
added a commit
to punchagan/opam-repo-ci
that referenced
this pull request
Jul 4, 2024
d6df6db in ocurrent#313 added a check to prevent use of extra-files in the opam-repository. Also, the repository doesn't contain any existing packages with extra-files. This means, we can get rid of the hash check for extra files in the linter.
punchagan
added a commit
to punchagan/opam-repo-ci
that referenced
this pull request
Jul 4, 2024
d6df6db in ocurrent#313 added a check to prevent use of extra-files in the opam-repository. Also, the repository doesn't contain any existing packages with extra-files. This means, we can get rid of the hash check for extra files in the linter.
punchagan
added a commit
to punchagan/opam-repo-ci
that referenced
this pull request
Jul 9, 2024
d6df6db in ocurrent#313 added a check to prevent use of extra-files in the opam-repository. This commit prevents the `files/` sub-directory from being present in the package directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a great alternative - extra-sources - that should be used instead.
The motivation is ocaml/opam-repository#25876, and this PR should be merged and put live once opam-repository is in the new state. I'll comment once this is the case.
I open this PR for (a) CI run (b) review, and (c) tracking the progress of ocaml/opam-repository#25876