Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to openpgp and ubuntu keyservers #1341

Merged
merged 2 commits into from
Jul 14, 2021
Merged

switch to openpgp and ubuntu keyservers #1341

merged 2 commits into from
Jul 14, 2021

Conversation

dvdherron
Copy link

@dvdherron dvdherron commented Jul 13, 2021

Steps to test/reproduce

  • running docker-compose build or (reopen in container in VSCode) with the old keyservers fails
  • doing the same with the updated keyservers should succeed

Context: nodejs/docker-node#1500 (comment)

@dvdherron dvdherron requested review from jgerigmeyer and jerivas July 13, 2021 16:40
@jerivas
Copy link
Member

jerivas commented Jul 13, 2021

Fix broken keyservers

@jerivas
Copy link
Member

jerivas commented Jul 14, 2021

Thanks @dvdherron, I was able to reproduce the issue and your fix does indeed solve it. I actually think SFDO will want to take a look at this for security. Would you like to open an upstream PR?

(Happy to open the PR myself if you prefer, it just felt more appropriate for you to be the PR author since you're the committer)

@dvdherron
Copy link
Author

Thanks @dvdherron, I was able to reproduce the issue and your fix does indeed solve it. I actually think SFDO will want to take a look at this for security. Would you like to open an upstream PR?

(Happy to open the PR myself if you prefer, it just felt more appropriate for you to be the PR author since you're the committer)

@jerivas done: SFDO-Tooling#2947
Let me know if anything looks weird.

@jerivas
Copy link
Member

jerivas commented Jul 14, 2021

@dvdherron looks good! I suggest drawing attention to the fact that docker builds are currently broken without this to make the severity clear.

@jgerigmeyer jgerigmeyer merged commit 2bdc89e into main Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants