Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated dependency upgrades #153

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Automated dependency upgrades #153

merged 3 commits into from
Mar 1, 2024

Conversation

github-actions[bot]
Copy link

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for oddcontrast ready!

Name Link
🔨 Latest commit afbd644
🔍 Latest deploy log https://app.netlify.com/sites/oddcontrast/deploys/65e20f9c1970be000835b933
😎 Deploy Preview https://deploy-preview-153--oddcontrast.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jgerigmeyer jgerigmeyer self-assigned this Jan 8, 2024
@jgerigmeyer jgerigmeyer force-pushed the auto-dependency-upgrades branch 2 times, most recently from 634d63f to 0405c21 Compare January 29, 2024 08:02
@jgerigmeyer jgerigmeyer force-pushed the auto-dependency-upgrades branch 2 times, most recently from 03bd1b4 to cbb11ad Compare February 12, 2024 08:02
@@ -11,6 +11,7 @@ export default defineConfig({
preprocessorOptions: {
scss: {
includePaths: [path.resolve('./src/sass/')],
pkgImporter: new NodePackageImporter('.'),
Copy link
Member

@jgerigmeyer jgerigmeyer Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, without this '.' I was getting the ol' error again:

failed to load config from /Users/jonny/Sites/oddcontrast/vite.config.ts
error during build:
The Node package importer cannot determine an entry point because `require.main.filename` is not defined. Please provide an `entryPointDirectory` to the `NodePackageImporter`.

🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm- my read of this is that it only matches if there are 2 arguments in the value of argv. The command that's getting run is yarn svelte:serve, which is vite dev --host 0.0.0.0, so it has 5 arguments.

Replacing svelte:serve with vite makes this work. If that sounds correct, I'll open a bug for Natalie to look at.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, yeah that makes sense 👍

@jgerigmeyer jgerigmeyer requested a review from jamesnw March 1, 2024 17:27
@jgerigmeyer
Copy link
Member

@jamesnw Package imports! Color.js v0.5! Yarn v4! All the shiny things! (Except sass-embedded, cause Vite doesn't support it yet.)

Copy link
Contributor

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@@ -11,6 +11,7 @@ export default defineConfig({
preprocessorOptions: {
scss: {
includePaths: [path.resolve('./src/sass/')],
pkgImporter: new NodePackageImporter('.'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm- my read of this is that it only matches if there are 2 arguments in the value of argv. The command that's getting run is yarn svelte:serve, which is vite dev --host 0.0.0.0, so it has 5 arguments.

Replacing svelte:serve with vite makes this work. If that sounds correct, I'll open a bug for Natalie to look at.

@jgerigmeyer jgerigmeyer merged commit c073cd0 into main Mar 1, 2024
7 checks passed
@jgerigmeyer jgerigmeyer deleted the auto-dependency-upgrades branch March 1, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants