-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated dependency upgrades #153
Conversation
✅ Deploy Preview for oddcontrast ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
59815ef
to
dcafa35
Compare
dcafa35
to
95509ec
Compare
95509ec
to
6137620
Compare
6137620
to
2e5ecc1
Compare
634d63f
to
0405c21
Compare
03bd1b4
to
cbb11ad
Compare
cbb11ad
to
5cab0d7
Compare
5cab0d7
to
e594af0
Compare
@@ -11,6 +11,7 @@ export default defineConfig({ | |||
preprocessorOptions: { | |||
scss: { | |||
includePaths: [path.resolve('./src/sass/')], | |||
pkgImporter: new NodePackageImporter('.'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, without this '.'
I was getting the ol' error again:
failed to load config from /Users/jonny/Sites/oddcontrast/vite.config.ts
error during build:
The Node package importer cannot determine an entry point because `require.main.filename` is not defined. Please provide an `entryPointDirectory` to the `NodePackageImporter`.
🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm- my read of this is that it only matches if there are 2 arguments in the value of argv
. The command that's getting run is yarn svelte:serve
, which is vite dev --host 0.0.0.0
, so it has 5 arguments.
Replacing svelte:serve
with vite
makes this work. If that sounds correct, I'll open a bug for Natalie to look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, yeah that makes sense 👍
@jamesnw Package imports! Color.js v0.5! Yarn v4! All the shiny things! (Except sass-embedded, cause Vite doesn't support it yet.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo!
@@ -11,6 +11,7 @@ export default defineConfig({ | |||
preprocessorOptions: { | |||
scss: { | |||
includePaths: [path.resolve('./src/sass/')], | |||
pkgImporter: new NodePackageImporter('.'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm- my read of this is that it only matches if there are 2 arguments in the value of argv
. The command that's getting run is yarn svelte:serve
, which is vite dev --host 0.0.0.0
, so it has 5 arguments.
Replacing svelte:serve
with vite
makes this work. If that sounds correct, I'll open a bug for Natalie to look at.
Full log: https://github.com/oddbird/oddcontrast/actions/runs/7245198850