-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post about masonry options #709
Conversation
View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..masonry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Don't forget to capitalize the first letter of masonry and syntax in the title.
- Where the bulleted lists items are complete sentences, I'd lean toward adding periods at the end.
- In the There’s a lot going on in that value bulleted list, there's a lot of text per bullet point. It's looking like a dense wall of text to me. I'm thinking it might actually feel easier to read if these were three paragraphs instead.
- Most of the time, you're using a colon before bulleted lists, but in the What's Next? section you switch to ellipses. I'd keep this consistent throughout.
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
@SondraE We have titles set to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great summary of current state of masonry. I know Adam Argyle was on Shop Talk Show a bit ago talking about this, and I haven't followed it much since I heard that. Good read.
On my personal site, | ||
image galleries fit this description perfectly. | ||
Maybe I'll start using it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link to an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't started using it yet. Or do you just mean, and example gallery that could be masonry-like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just meant to see what kind of gallery you currently have that could use it. No pressure though, I was just curious
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
* main: Bump the npm-minor-upgrades group with 4 updates lint Bump @rollup/plugin-commonjs in the npm-major-upgrades group Automated webmentions update Fix sass color errors
@jgerigmeyer @stacyk @SondraE - I made some updates based on the CSS Tricks post. If any of you have a chance to do final sign-off, I can publish either this afternoon or tomorrow morning. |
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Description
Uncomment if you want to provide a custom description.
As pr usual:
Related Issue(s)
Reminder to add related issue(s), if available.