Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post about masonry options #709

Merged
merged 10 commits into from
Oct 1, 2024
Merged

Blog post about masonry options #709

merged 10 commits into from
Oct 1, 2024

Conversation

mirisuzanne
Copy link
Member

@mirisuzanne mirisuzanne commented Sep 29, 2024

Description

Uncomment if you want to provide a custom description.

As pr usual:

  • I wrote a different post than I had planned on
  • It still needs:
    • An image
    • tags
    • a summary

Related Issue(s)

Reminder to add related issue(s), if available.

  • none, yet

Copy link

View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..masonry

Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
@mirisuzanne mirisuzanne linked an issue Sep 30, 2024 that may be closed by this pull request
Copy link
Contributor

@SondraE SondraE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirisuzanne

  • Don't forget to capitalize the first letter of masonry and syntax in the title.
  • Where the bulleted lists items are complete sentences, I'd lean toward adding periods at the end.
  • In the There’s a lot going on in that value bulleted list, there's a lot of text per bullet point. It's looking like a dense wall of text to me. I'm thinking it might actually feel easier to read if these were three paragraphs instead.
  • Most of the time, you're using a colon before bulleted lists, but in the What's Next? section you switch to ellipses. I'd keep this consistent throughout.

Why does this wrap after we?
Screenshot 2024-09-30 at 10 17 52 AM

Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
@mirisuzanne
Copy link
Member Author

Why does this wrap after we?

@SondraE We have titles set to text-wrap: balance - so when it wraps, it tries to balance the lines. The alternative is that we might get widows on the new line when it wraps.

Copy link
Member

@stacyk stacyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great summary of current state of masonry. I know Adam Argyle was on Shop Talk Show a bit ago talking about this, and I haven't followed it much since I heard that. Good read.

content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
Comment on lines 399 to 401
On my personal site,
image galleries fit this description perfectly.
Maybe I'll start using it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to an example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't started using it yet. Or do you just mean, and example gallery that could be masonry-like?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just meant to see what kind of gallery you currently have that could use it. No pressure though, I was just curious

content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
mirisuzanne and others added 3 commits September 30, 2024 12:22
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
* main:
  Bump the npm-minor-upgrades group with 4 updates
  lint
  Bump @rollup/plugin-commonjs in the npm-major-upgrades group
  Automated webmentions update
  Fix sass color errors
@mirisuzanne
Copy link
Member Author

@jgerigmeyer @stacyk @SondraE - I made some updates based on the CSS Tricks post. If any of you have a chance to do final sign-off, I can publish either this afternoon or tomorrow morning.

content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
content/blog/2024/grid-masonry-nuance.md Outdated Show resolved Hide resolved
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
@mirisuzanne mirisuzanne merged commit 89cdecd into main Oct 1, 2024
10 checks passed
@mirisuzanne mirisuzanne deleted the masonry branch October 1, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog post about Masonry
4 participants