Skip to content

Commit

Permalink
Merge pull request #128 from oddbird/drop-open-styles
Browse files Browse the repository at this point in the history
drop :open styles
  • Loading branch information
jgerigmeyer authored Sep 18, 2023
2 parents 19d04b0 + d0189d8 commit edae6c2
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 23 deletions.
6 changes: 5 additions & 1 deletion .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"extends": "stylelint-config-standard",
"rules": {
"selector-type-no-unknown": null
"declaration-block-no-redundant-longhand-properties": null,
"selector-class-pattern": null,
"selector-pseudo-class-no-unknown": null,
"selector-type-no-unknown": null,
"value-no-vendor-prefix": null
}
}
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Popover Attribute Polyfill Changelog

## UNRELEASED

- 💥 BREAKING: Drop `:open` styles --
[#128](https://github.com/oddbird/popover-polyfill/pull/128)
- 📝 DOCS: Fix link in README --
[#108](https://github.com/oddbird/popover-polyfill/pull/108)
- 🏠 INTERNAL: Upgrade dependencies

## 0.2.2: 2023-06-06

- 🚀 NEW: Add support for older browsers, e.g. Firefox 91, Chrome ~80 --
Expand Down
22 changes: 0 additions & 22 deletions src/popover.css
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
margin: auto;
}

/* stylelint-disable selector-class-pattern */
[popover]:not(.\:popover-open) {
display: none;
}
Expand All @@ -28,32 +27,15 @@
inset: auto;
}

/* This older `:open` pseudo selector is deprecated and support will be removed
in a later release. */
@supports selector([popover]:open) {
[popover]:not(.\:popover-open, dialog[open]) {
display: revert;
}

/* stylelint-disable selector-pseudo-class-no-unknown */
[anchor]:is(:open) {
inset: auto;
}
/* stylelint-enable selector-pseudo-class-no-unknown */
}

@supports selector([popover]:popover-open) {
[popover]:not(.\:popover-open, dialog[open]) {
display: revert;
}

/* stylelint-disable selector-pseudo-class-no-unknown */
[anchor]:is(:popover-open) {
inset: auto;
}
/* stylelint-enable selector-pseudo-class-no-unknown */
}
/* stylelint-enable selector-class-pattern */

@supports not (background-color: canvas) {
[popover] {
Expand All @@ -64,20 +46,16 @@ in a later release. */

@supports (width: -moz-fit-content) {
[popover] {
/* stylelint-disable value-no-vendor-prefix */
width: -moz-fit-content;
height: -moz-fit-content;
/* stylelint-enable value-no-vendor-prefix */
}
}

@supports not (inset: 0) {
[popover] {
/* stylelint-disable declaration-block-no-redundant-longhand-properties */
top: 0;
left: 0;
right: 0;
bottom: 0;
/* stylelint-enable declaration-block-no-redundant-longhand-properties */
}
}

0 comments on commit edae6c2

Please sign in to comment.