-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add click to copy input and output #71
Conversation
Questions for @SondraE -
|
No need
Let's go with the placement of the buttons in the corner of each box as you show above.
When selected, change each copy button to a checkmark for a few seconds. Also add the success message to the existing copy message banner space. |
Feedback from Natalie on a PR I accidentally opened in the wrong repo 🤦 -
|
@mirisuzanne and @stacyk This is ready for design. |
✅ Deploy Preview for sass-site-oddbird ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesnw did you want to review this before we send it on?
class="sl-c-button sl-c-button--copy sl-c-button--icon-text"> | ||
<div class="sl-c-playground-button--copy--copy"> | ||
{%- render 'icons/copy' -%} | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the "Click to Copy" screen reader text here since the icon is paired with actual text in the button that says "button, Copy URL" so it felt unnecessary here.
</div> | ||
<div class="sl-c-playground-button--copy--copied"> | ||
{%- render 'icons/circle-check' -%} | ||
<span class="visuallyhidden">URL is Copied</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the message here since the state is only shown visually, this message communicates that the URL has been copied.
</div> | ||
<div class="sl-c-playground-button--copy--copied"> | ||
{%- render 'icons/circle-check' -%} | ||
<span class="visuallyhidden">Code is Copied</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using the screen reader, it was really hard to distinguish between the Select to "Copy" and the word "Copied" that is read right after. They sounded the exact same to me so I added the "Code is" before the word "Copied".
class="sl-c-button sl-c-button--copy sl-c-button--icon"> | ||
<div class="sl-c-playground-button--copy--copy"> | ||
{%- render 'icons/copy' -%} | ||
<span class="visuallyhidden">Select to Copy</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this to "Select" instead of "click" incase someone is on a touch screen.
Moved to sass#1177 |
Original design
TODO