Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground color #84

Closed
wants to merge 9 commits into from
Closed

Playground color #84

wants to merge 9 commits into from

Conversation

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for sass-site-oddbird ready!

Name Link
🔨 Latest commit 96e0240
🔍 Latest deploy log https://app.netlify.com/sites/sass-site-oddbird/deploys/66ff0bb7a7c973000865b04a
😎 Deploy Preview https://deploy-preview-84--sass-site-oddbird.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jamesnw jamesnw linked an issue Sep 23, 2024 that may be closed by this pull request
@jamesnw
Copy link
Author

jamesnw commented Sep 25, 2024

@stacyk This is ready for you. A few notes-

  • I am generating the markup, and can change it to whatever makes things easiest
  • The emoji font is copy pasted, should probably be brought in better from typography
  • I'm unsure if setting the title is the best way of getting a tooltip
  • The grid in the debug console is making it stack- if needed, I can wrap the whole message in a div

@jamesnw jamesnw marked this pull request as ready for review September 25, 2024 14:26
@stacyk
Copy link
Member

stacyk commented Oct 3, 2024

@jamesnw want to take a look and see if you think it is ready for review?

@stacyk stacyk assigned jamesnw and unassigned stacyk Oct 3, 2024
@stacyk stacyk self-requested a review October 3, 2024 20:58
@jamesnw
Copy link
Author

jamesnw commented Oct 3, 2024

Moved to sass#1214

@jamesnw jamesnw closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playground- Color Swatches
2 participants