Upgrade deps and address Sass deprecation warnings. #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for herman-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jgerigmeyer
commented
Nov 8, 2024
There was a problem hiding this comment.
@mirisuzanne @stacyk I don't really understand the changes I'm making to Sass, so I'd appreciate review from one or both of you! 🙏
scss/config/_colors.scss
Outdated
| @@ -62,17 +62,23 @@ $neutral-colors: ( | |||
| 'light-gray': '#brand-blue' | |||
| ( | |||
| 'tint': 80%, | |||
| 'desaturate': 80%, | |||
| 'color.scale': ( | |||
There was a problem hiding this comment.
Should these be using color.adjust instead?
There was a problem hiding this comment.
@jgerigmeyer in our case since we want to match the colors we have already established and tested, color.adjust will give us the same colors we had before.
* main: Bump webpack in the npm-minor-upgrades group across 1 directory Bump the npm-minor-upgrades group with 13 updates Bump sinon from 18.0.1 to 19.0.2 in the npm-major-upgrades group
stacyk
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.