Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete the Jest DI with crypto #234
Complete the Jest DI with crypto #234
Changes from 1 commit
e6311df
88d6097
21e43ce
dbc3b3d
d391663
3cc7931
71a0796
376a3d6
d08d0ce
b8ffa04
f9b594c
830ae07
08d6833
4ad48db
feed976
9409e0e
39a6695
20de6bd
7015861
63bdbcc
409f287
eab6bc8
5cbfd03
c5d97ce
796acae
d475e48
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I duplicate some code here from keystore-idb.
We should probably eventually make it possible to use our dependencies in node. However, doing that for keystore-idb could be questionable, given it has "idb" in its name 😄
Any way, this feels kind of quick-and-dirty right now. Let me know if you have any other ideas.