Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findByPath: handle files clashing by path #356

Closed
wants to merge 3 commits into from

Conversation

odeke-em
Copy link
Owner

This PR is a work in progress (not complete) to fix up a couple of bugs that were caused due to the design remote findBy* functions with local filesystem inherent behaviour for a remote that allows path duplication e.g
FindByPath(...) previously returned a single file
However
FindByPath(...) actually picked the first path presented to it because Google Drive can allow for different files to have the same relative path, with no problem but the local file system will not.

With the new behaviour, a FindByPath call should return all found files.

This kind of old behaviour causes issues like not all the clashes being listed, not fully urlifying nor opening files, not properling list-ing, stat-ing and many others.

@odeke-em
Copy link
Owner Author

Closing in favor of more superior PR #528

@odeke-em odeke-em closed this Dec 24, 2015
@odeke-em odeke-em deleted the finder-handle-duplicates branch February 4, 2016 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant