findByPath: handle files clashing by path #356
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress (not complete) to fix up a couple of bugs that were caused due to the design remote findBy* functions with local filesystem inherent behaviour for a remote that allows path duplication e.g
FindByPath(...) previously returned a single file
However
FindByPath(...) actually picked the first path presented to it
because Google Drive can allow for different files to have the same relative path, with no problem but the local file system will not.With the new behaviour, a FindByPath call should return all found files.
This kind of old behaviour causes issues like not all the clashes being listed, not fully urlifying nor opening files, not properling
list-ing
,stat-ing
and many others.