share: anyone with link, not publicly published #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow sharing of file with `anyone with link` without having to publish it to the internet. Publishing is different because after a file is published, it is indexed (See #568 (comment)). We don't want the file to be indexed, but just accessible by anyone with a link to it. ```shell $ drive share --type user,anyone,anyone,user --role reader,anyone --emails "emm.odeke@gmail.com" outf.gif Provide access for accountType(s) user anyone For roles(s) reader Addressees: + emm.odeke@gmail.com + Anyone with the link File(s) to share: + outf.gif Proceed with the changes? [Y/n]:y successful share for outf.gif with email "emm.odeke@gmail.com", role "reader" accountType "user" successful share for outf.gif with email "", role "reader" accountType "anyone" ``` Fixes #568.
|
Testing it right now but it still is public and indexed, |
|
Hello @thebaddie. Thank you for the test. Yes, I noticed that with drive/v2 this option isn't provided. We should probably start moving over to drive/v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sharing of file with
anyone with linkwithouthaving to publish it to the internet. Publishing is different
because after a file is published, it is indexed
(See #568 (comment)).
We don't want the file to be indexed, but just accessible by anyone with
a link to it.
Fixes #568.