Skip to content

Commit

Permalink
Merge pull request #186 from wbrunette/sep21
Browse files Browse the repository at this point in the history
upgrade dependencies, remove multi-dex
  • Loading branch information
wbrunette authored Sep 4, 2021
2 parents c8d9cb3 + 52d7de3 commit 688628b
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 46 deletions.
11 changes: 5 additions & 6 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,20 @@
buildscript {
repositories {
google()
jcenter()
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:4.1.3'
classpath 'org.jfrog.buildinfo:build-info-extractor-gradle:4.9.8'
classpath 'com.google.gms:google-services:4.3.5'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.5.2'
classpath 'com.android.tools.build:gradle:4.2.2'
classpath 'org.jfrog.buildinfo:build-info-extractor-gradle:4.23.4'
classpath 'com.google.gms:google-services:4.3.10'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.7.1'
}
}

allprojects {
repositories {
google()
jcenter()
mavenCentral()
maven {
url "https://jitpack.io"
}
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-all.zip
18 changes: 5 additions & 13 deletions settings.gradle
Original file line number Diff line number Diff line change
@@ -1,16 +1,8 @@
gradle.ext.gradleConfigVersion = 150

if ( !gradle.ext.has('workspacePath') ) {
def env = System.getProperties();
logger.warn("tables/settings.gradle System.getProperties().stringPropertyNames(): " + env.stringPropertyNames());
def path = System.getProperty('com.android.studio.gradle.project.path');
if ( path != null ) {
logger.warn("tables/settings.gradle Found value for System.getProperty('com.android.studio.gradle.project.path')");
gradle.ext.workspacePath = (new File(path)).getParentFile().getAbsolutePath();
} else {
logger.warn("tables/settings.gradle No value found for System.getProperty('com.android.studio.gradle.project.path')");
gradle.ext.workspacePath = new File("..").getAbsolutePath();
}
gradle.ext.gradleConfigVersion = 152

if (!gradle.ext.has('workspacePath')) {
logger.warn("rootDir: " + rootDir.getAbsolutePath());
gradle.ext.workspacePath = rootDir.getParentFile().getAbsolutePath();
}

logger.warn('tables/settings.gradle -- gradle.ext.workspacePath: ' + gradle.ext.workspacePath)
Expand Down
29 changes: 13 additions & 16 deletions tables_app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ android {

testApplicationId(groupId + tablesName + testNameSuffix)
testInstrumentationRunner(instrumentationRunner)

multiDexEnabled true
}

flavorDimensions "stage", "testing"
Expand Down Expand Up @@ -126,17 +124,16 @@ allprojects {
dependencies {
implementation 'androidx.annotation:annotation:1.2.0'
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
implementation 'androidx.fragment:fragment:1.3.2'
implementation 'androidx.fragment:fragment:1.3.6'
implementation 'androidx.preference:preference:1.1.1'
implementation 'androidx.appcompat:appcompat:1.2.0'
implementation 'androidx.recyclerview:recyclerview:1.1.0'
implementation 'com.google.android.material:material:1.3.0'
implementation 'androidx.appcompat:appcompat:1.3.1'
implementation 'androidx.recyclerview:recyclerview:1.2.1'
implementation 'com.google.android.material:material:1.4.0'
implementation 'com.github.wbrunette:ProgressWheel:3.4'

implementation 'com.google.firebase:firebase-analytics:18.0.2'
implementation 'com.google.firebase:firebase-crashlytics:17.4.1'
implementation 'com.google.firebase:firebase-analytics:19.0.1'
implementation 'com.google.firebase:firebase-crashlytics:18.2.1'

implementation 'androidx.multidex:multidex:2.0.1'

if (libraryProjectPath.exists() && gradle.useLocal) { // Local project is favoured
implementation project(libraryProjectName)
Expand All @@ -160,15 +157,15 @@ dependencies {
classifier: snapshotRelease, version: latestVersion, ext: 'aar')
}

implementation 'com.google.android.gms:play-services-maps:17.0.0'
implementation 'com.google.android.gms:play-services-maps:17.0.1'

//for Espresso
androidTestUitestImplementation 'androidx.test:runner:1.3.0'
androidTestUitestImplementation 'androidx.test:rules:1.3.0'
androidTestUitestImplementation 'androidx.test.espresso:espresso-core:3.3.0'
androidTestUitestImplementation 'androidx.test.espresso:espresso-intents:3.3.0'
androidTestUitestImplementation 'androidx.test.espresso:espresso-web:3.3.0'
androidTestUitestImplementation 'androidx.test.espresso:espresso-contrib:3.3.0'
androidTestUitestImplementation 'androidx.test:runner:1.4.0'
androidTestUitestImplementation 'androidx.test:rules:1.4.0'
androidTestUitestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
androidTestUitestImplementation 'androidx.test.espresso:espresso-intents:3.4.0'
androidTestUitestImplementation 'androidx.test.espresso:espresso-web:3.4.0'
androidTestUitestImplementation 'androidx.test.espresso:espresso-contrib:3.4.0'
androidTestUitestImplementation 'androidx.annotation:annotation:1.2.0'

//for UI Automator
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

import android.content.Context;

import androidx.multidex.MultiDex;

import com.google.firebase.analytics.FirebaseAnalytics;
import org.opendatakit.application.CommonApplication;
import org.opendatakit.tables.R;
Expand Down Expand Up @@ -45,14 +43,7 @@ public static Tables getInstance() {
throw new IllegalStateException("not possible");
return ref.get();
}

@Override
protected void attachBaseContext(Context base) {
super.attachBaseContext(base);
MultiDex.install(this);
}



@Override
public int getApkDisplayNameResourceId() {
return R.string.app_name;
Expand Down

0 comments on commit 688628b

Please sign in to comment.