Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE][REF] delivery: extract stock logic in separate module #110686

Conversation

vava-odoo
Copy link
Contributor

@vava-odoo vava-odoo commented Jan 23, 2023

It's currently impossible to set fixed delivery costs in eCommerce without installing Inventory. This is a problem for one-app free instances on our SaaS, which would need to pay for a feature that should be part of the basic eCommerce features bundle.

Delivery is now split from inventory/stock module to allow for a soft free integration into website_sale. This PR makes it possible to define fixed-cost delivery methods in eCommerce without installing Inventory by adding a direct dependency of website_sale on delivery. The bridge between those two modules is therefore included in the former.

Steps are:

  • extract the Inventory logic from the delivery module into a new stock_delivery module;
  • move website_sale_delivery into website_sale;
  • adapt dependencies to delivery and website_sale_delivery;
  • remove bridge module with loyalty directly in website_sale_loyalty;
  • move website_sale_delivery_mondialrelay to website_sale_mondialrelay.

task-3074497
task-3203210

See also:

@robodoo
Copy link
Contributor

robodoo commented Jan 23, 2023

Pull request status dashboard

@C3POdoo C3POdoo added the RD research & development, internal work label Jan 23, 2023
@vava-odoo vava-odoo force-pushed the master-delivery_split_from_sale_and_stock-vava branch 12 times, most recently from 83d1956 to 771d608 Compare January 26, 2023 16:56
@vava-odoo vava-odoo force-pushed the master-delivery_split_from_sale_and_stock-vava branch 16 times, most recently from 8d5d9a0 to 5fbadfa Compare February 6, 2023 10:54
It's currently impossible to set fixed delivery costs in eCommerce
without installing Inventory. This is a problem for one-app free
instances on our SaaS, which would need to pay for a feature that
should be part of the basic eCommerce features bundle.

This commit makes it possible to define fixed-cost delivery methods in
eCommerce without installing Inventory by adding a direct dependency of
`website_sale` on `delivery`. The bridge between those two modules is
therefore included in the former.
*: mondialrelay, stock_picking_batch
**: delivery_mondialrelay, loyalty_delivery, picking

Adapt dependency to `website_sale` directly instead of
`website_sale_delivery`.
In ecommerce, the form vue of shipping methods should be improved to
easily set up fixed delivery costs. This commit improves the
user-experience and solves bugs on the fields displayed.

task-3203210
@Feyensv Feyensv force-pushed the master-delivery_split_from_sale_and_stock-vava branch from 5317a2c to 28799be Compare March 13, 2023 21:59
@Feyensv
Copy link
Contributor

Feyensv commented Mar 13, 2023

@robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Mar 14, 2023

@vava-odoo @Feyensv linked pull request(s) odoo/enterprise#36609 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Mar 14, 2023
Extract the Inventory logic from the `delivery` module into a new
`stock_delivery` module. This will allow to integrate the basic delivery
features into the website_sale app in a one-app free database.

task-3074497

Part-of: #110686
robodoo pushed a commit that referenced this pull request Mar 14, 2023
It's currently impossible to set fixed delivery costs in eCommerce
without installing Inventory. This is a problem for one-app free
instances on our SaaS, which would need to pay for a feature that
should be part of the basic eCommerce features bundle.

This commit makes it possible to define fixed-cost delivery methods in
eCommerce without installing Inventory by adding a direct dependency of
`website_sale` on `delivery`. The bridge between those two modules is
therefore included in the former.

Part-of: #110686
robodoo pushed a commit that referenced this pull request Mar 14, 2023
*: mondialrelay, stock_picking_batch
**: delivery_mondialrelay, loyalty_delivery, picking

Adapt dependency to `website_sale` directly instead of
`website_sale_delivery`.

Part-of: #110686
robodoo pushed a commit that referenced this pull request Mar 14, 2023
robodoo pushed a commit that referenced this pull request Mar 14, 2023
In ecommerce, the form vue of shipping methods should be improved to
easily set up fixed delivery costs. This commit improves the
user-experience and solves bugs on the fields displayed.

task-3203210

Part-of: #110686
robodoo pushed a commit that referenced this pull request Mar 14, 2023
robodoo added a commit that referenced this pull request Mar 14, 2023
It's currently impossible to set fixed delivery costs in eCommerce without installing Inventory. This is a problem for one-app free instances on our SaaS, which would need to pay for a feature that should be part of the basic eCommerce features bundle.

Delivery is now split from inventory/stock module to allow for a soft free integration into website_sale. This PR makes it possible to define fixed-cost delivery methods in eCommerce without installing Inventory by adding a direct dependency of `website_sale` on `delivery`. The bridge between those two modules is therefore included in the former.

Steps are:
- extract the Inventory logic from the `delivery` module into a new `stock_delivery` module;
- move `website_sale_delivery` into `website_sale`;
- adapt dependencies to `delivery` and `website_sale_delivery`;
- remove bridge module with loyalty directly in `website_sale_loyalty`;
- move `website_sale_delivery_mondialrelay` to `website_sale_mondialrelay`.

task-3074497
task-3203210

See also:
- odoo/enterprise#36609
- odoo/upgrade#4362

closes #110686

Related: odoo/upgrade#4362
Related: odoo/enterprise#36609
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo temporarily deployed to merge March 14, 2023 12:29 Inactive
@robodoo robodoo closed this Mar 14, 2023
@robodoo robodoo added the 16.2 label Mar 14, 2023
@fw-bot fw-bot deleted the master-delivery_split_from_sale_and_stock-vava branch March 28, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16.2 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants