Palm frag #10
Closed
Palm frag #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before there was no concept of fragments and the layout step was taking the box tree as input and saving the used layout metrics into boxes themselves. This commit introduces the concept of Fragments, Fragmentainers and Fragmentation Context (https://drafts.csswg.org/css-break-4/#fragmentation-model). Currently, only pages, the block formatting context, and PDF under the 'print' command are supported. The commit mechanism was changed from an enum (yes/no) to support these new concepts. Now, since layouting the box tree generates the Fragment tree, a layout call that should commit a Fragment for a Box into the Fragment tree will: - create the said Fragment - pass a reference to the said Fragment to it child call - add the created Fragment to the list of children of its parent in the Fragment tree by using the passed reference To Fragment, breakpoints with appeal were implemented, following Chrome, https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/blink/renderer/core/layout/block_fragmentation_tutorial.md and its golden rule > Break at the breakpoint with the highest appeal (primary criterion) that also fits as much content as possible (secondary criterion). Co-authored-by: Paulo Medeiros <palm@odoo.com> Co-authored-by: Nicolas Van Bossuyt <nivb@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.