Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movistar+ multiple regions #280

Closed
wants to merge 1 commit into from
Closed

Movistar+ multiple regions #280

wants to merge 1 commit into from

Conversation

miberian
Copy link
Contributor

Changes to provider files to support region 0x82 and merge with 0x83. This produces official channel order. This is now achieved without code changes.

Changes to provider files to support region 0x82 and merge with 0x83. This produces official channel order.
@Huevos
Copy link
Member

Huevos commented Sep 20, 2023

Ok, but in one file, not two...

And you wanted 0x82 and 0x83 at the same time, right?

@miberian
Copy link
Contributor Author

Yes both 0x82 and 0x83 are required to get the full channel list. I don’t believe this can be done in a single xml without code changes to dvbscanner.

@miberian
Copy link
Contributor Author

And please note that since the new file depends on the existing/main one there is no impact to usability. Users will still see a single provider in the UI.

Downside of this approach compared to code changes is that it takes twice the time for processing.

@Huevos
Copy link
Member

Huevos commented Sep 20, 2023

Ok, let me look at it.

@Huevos
Copy link
Member

Huevos commented Sep 20, 2023

<visibleserviceflag ignore="1"/>

Why do you remove this?

@miberian
Copy link
Contributor Author

miberian commented Sep 21, 2023

The main file now has to be configured for 0x82 to produce the correct channel list. Descriptor 0x82 does not have visible_service_flag so I removed the configuration from that file as it is not really needed (it has no effect). However, it is still required for 0x83 so the configuration remains as the previous version in sat_192_movistar_plus_esp_0x83.xml.

@Huevos
Copy link
Member

Huevos commented Sep 21, 2023

Please see latest commits (in particular):
cf08f3f
5c0a58a

But obviously make sure you test with all commits.

1

@miberian
Copy link
Contributor Author

No longer required.

@miberian miberian closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants