Add option to auto-select Koch lesson after symbol is keyed correctly multiple times in a row #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosePadron
commented
Oct 22, 2021
| @@ -73,7 +73,8 @@ const String menuText [menuN] = { | |||
| "Wifi Select", //40 | |||
|
|
|||
|
|
|||
| "Go To Sleep" } ; // 41 | |||
| "Go To Sleep", // 41 | |||
| "Auto Selection" } ; // 42 Koch | |||
There was a problem hiding this comment.
New menu string to select max number of times a symbol should be keyed correctly before moving to next lesson.
There was a problem hiding this comment.
I put new menu and strings at the end to avoid shifting everything
JosePadron
commented
Oct 22, 2021
| @@ -120,7 +121,8 @@ const uint8_t menuNav [menuN] [5] = { // { level, left, right, | |||
| {1,_wifi_check,_wifi_update,_wifi,0}, // 38 Upload File | |||
| {1,_wifi_upload,_wifi_select,_wifi,0}, // 39 Update Firmware | |||
| {1,_wifi_update,_wifi_mac,_wifi,0}, // 40 Select network | |||
| {0,_wifi,_keyer,_dummy,0} // 41 goto sleep | |||
| {0,_wifi,_keyer,_dummy,0}, // 41 goto sleep | |||
| {1,_kochEcho,_kochSel,_koch,0}, // 42 koch Auto select check 16 | |||
There was a problem hiding this comment.
New menu between Echo and Select Lesson
JosePadron
commented
Oct 22, 2021
| @@ -105,7 +105,8 @@ Preferences pref; // use the Preferences library for storing and r | |||
| uint8_t MorsePreferences::snapShots = 0; // keep track which snapshots are being used ( 0 .. 7, called 1 to 8) | |||
|
|
|||
| uint8_t MorsePreferences::boardVersion = 0; // which Morserino board version? v3 uses heltec Wifi Lora V2, V4 uses V2.1 | |||
|
|
|||
|
|
|||
| uint8_t MorsePreferences::okKeyingMaxCount = 0; // Max number of correct keying before moving to next lesson | |||
JosePadron
commented
Oct 22, 2021
| @@ -855,6 +858,10 @@ boolean MorsePreferences::adjustKeyerPreference(prefPos pos) { /// rotati | |||
| internal::displayKochFilter(); | |||
| break; | |||
|
|
|||
| case posKochAutoSel: MorsePreferences::okKeyingMaxCount = constrain(MorsePreferences::okKeyingMaxCount + t, 0, 100); | |||
JosePadron
changed the title
|
Jose, this will require some testing before I can commit it. |
I understand. Let me know if you need anything else from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #45