Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make install of Perl modules with a custom DESTDIR and/or libdir #652

Merged
merged 10 commits into from
May 28, 2024

Conversation

jimklimov
Copy link
Contributor

@jimklimov jimklimov commented May 27, 2024

Closes: #646
Closes: #651

Checked fixed with GNU Make on Ubuntu 22, illumos make on OpenIndiana, BSD make on FreeBSD 12.

See "screenshot" at #646 (comment)

…s for the build [oetiker#651]

Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
… MAKEFLAGS when retrying in case it fails due to random fuzzy logic of cpanm [oetiker#651]

Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…n make [oetiker#651]

Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…all") and PERL_MODULES_EXTRA_DIST (for dist tarballing) [oetiker#646]

Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Copy link

@check-spelling-bot Report jimklimov/znapzend: issue-646 into -> oetiker/znapzend: 23f0923

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 2

See ❌ Event descriptions for more information.

Previously acknowledged words that are now absent Balert Bcreate Bdebug Bdelete Bedit Berr Bexport Bimport Binfo Bnoaction Bnot Bpidfile Bpost Bpre Bsyslog Bwarning Bzfs Bznapzend Bznapzendzetup Bznapzendztatz cpanfile cpanm cpanmin CPANSNAPV crt DBD DESTDIR distdir DTDs endif EXTRADIST forkcall Icommand Icommon Icreate Idataset Idestroy Idocuments Iexport Ifacility Ifeature Ifilepath Ihome Ilimited imandir Inumber Ioptions Ipath Ipictures Irecursive Isend Iskip Isnapshots Isnapsuffix Isources Itank Ithirdparty Itimeout Iusbbackup Iuser Ivalue Iznapzendzetup lpr nobase notest nroff ODBC SUBDIRS svcdir troff unicode utf vroff xargs 🫥
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (668) from .github/workflows//spelling/expect.txt and unrecognized words (0)

Dictionary Entries Covers Uniquely
cspell:software-terms/dict/softwareTerms.txt 1288 82 18
cspell:php/dict/php.txt 1689 59 6
cspell:python/src/python/python-lib.txt 2417 54 6
cspell:node/dict/node.txt 891 58 5
cspell:filetypes/filetypes.txt 264 19 4

Consider adding them (in .github/workflows/spelling.yml):

      with:
        extra_dictionaries:
          cspell:software-terms/dict/softwareTerms.txt
          cspell:php/dict/php.txt
          cspell:python/src/python/python-lib.txt
          cspell:node/dict/node.txt
          cspell:filetypes/filetypes.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml):

check_extra_dictionaries: ''

Follow-up for commit cf0e4b1 and for new cpanfile samples

Signed-off-by: Jim Klimov <jimklimov@gmail.com>
oetiker
oetiker previously approved these changes May 28, 2024
@oetiker
Copy link
Owner

oetiker commented May 28, 2024

thanks!

@jimklimov
Copy link
Contributor Author

Right, thanks for the CHANGES :)

@jimklimov
Copy link
Contributor Author

jimklimov commented May 28, 2024

For historic note about this fix: it seems that make DESTDIR=... install as the first and only make invocation in the use-case I had here could have been the culprit about not succeeding with cpanm/carton preparation phases (subsequent modules could not find their dependencies in THIRDPARTY_DIR probably), at least greater a problem than parallelism. The former is easy to prove experimentally, the latter less so :)

@oetiker oetiker merged commit a5480d1 into oetiker:master May 28, 2024
4 checks passed
@jimklimov jimklimov deleted the issue-646 branch May 28, 2024 10:13
jimklimov added a commit to jimklimov/znapzend that referenced this pull request May 28, 2024
jimklimov added a commit to jimklimov/znapzend that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants